Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HITL - Change async network process loop. #1875

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Mar 22, 2024

Motivation and Context

Currently, when an exception occurs on the network process, it just stops silently. This makes it difficult to iterate.

This PR changes the asyncio structures such as an error is printed when an exception occurs.

How Has This Been Tested

Tested with remote clients (stub, Unity single player and Unity multiplayer).

Types of changes

  • [Refactoring]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 22, 2024
@0mdc 0mdc merged commit de68e1e into main Mar 26, 2024
4 checks passed
@0mdc 0mdc deleted the 0mdc/networking_process_loop branch March 26, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants