Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HITL - [Placeholder interface] Prevent placing objects when placement is impossible. #1882

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Mar 28, 2024

Motivation and Context

This small change prevents placement of objects when placement is impossible.

This is a placeholder interface and will be mostly replaced.

How Has This Been Tested

Tested locally.

Types of changes

  • [Bug Fix]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested review from jturner65 and aclegg3 March 28, 2024 18:42
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 28, 2024
@0mdc 0mdc changed the title HITL - [Placeholder interface] Place objects back to their original position when placement fails. HITL - [Placeholder interface] Prevent placing objects when placement is impossible. Mar 28, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to block placing for some reasons.

@0mdc 0mdc merged commit b6c9501 into main Apr 1, 2024
4 checks passed
@0mdc 0mdc deleted the 0mdc/fix_object_placement branch April 1, 2024 23:54
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
… is impossible. (facebookresearch#1882)

* Place objects back to their original position when placement fails.

* Cancel placement if not possible.

* Formatting fixes.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
… is impossible. (facebookresearch#1882)

* Place objects back to their original position when placement fails.

* Cancel placement if not possible.

* Formatting fixes.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
… is impossible. (facebookresearch#1882)

* Place objects back to their original position when placement fails.

* Cancel placement if not possible.

* Formatting fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants