-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AnyObjectReceptacle #1924
Merged
Merged
AnyObjectReceptacle #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Apr 25, 2024
rutadesai
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Excited to integrate this when ready :)
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jun 26, 2024
* add AnyObjectReceptacle initial implementation
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* add AnyObjectReceptacle initial implementation
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* add AnyObjectReceptacle initial implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR introduces the
AnyObjectReceptacle
. This allows any object in the simulation to be used as a Receptacle by implementing the Receptacle API in a generic way:Future Improvements/iterative work:
bounds
attribute cannot be computed because Receptacle does not expect access to sim for this.How Has This Been Tested
Added a unit test.
Local testing in example app. The video below takes place in a ReplicaCAD scene. Pre-configured AABBReceptacles already exist in the scene. Some objects do not have Receptacles configured. When the user clicks such an object, an AnyObjectReceptacle is added. This can then be used to sample snap_down placements.
Notice that these placements are not very good (especially with dynamic simulation stability). That's why we annotate Receptacles instead of using this approach in general. However, this is better than nothing and should serve for kinematic use cases.
any_object_receptacle-2024-04-25_15.38.22.mp4
Types of changes
Checklist