Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Add dedicated kick queue. #1931

Merged
merged 1 commit into from
May 3, 2024
Merged

HITL - Add dedicated kick queue. #1931

merged 1 commit into from
May 3, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented May 1, 2024

Motivation and Context

This change adds a dedicated kick command queue to HITL.

The previous system was relying on Server->Client messaging to process kicking. This hacky setup had a couple issues:

  • Need to filter-out kick messages when consolidating keyframes.
  • Difficulty controlling when kicking happens. For example, sometimes, we want to send messages to the user before kicking.
  • Add complexity to the message queue.

How Has This Been Tested

Tested on downstream multiplayer HITL system and locally.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested a review from aclegg3 May 1, 2024 00:36
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 1, 2024
@0mdc 0mdc requested review from jturner65 and zephirefaith May 1, 2024 00:36
aclegg3
aclegg3 approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from my limited context. 👍

@0mdc 0mdc merged commit eed9606 into main May 3, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/dedicated_kick_queue branch May 3, 2024 12:26
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@0mdc @dannymcy
Add dedicated kick queue for HITL. (facebookresearch#1931)
5a636ca
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
Add dedicated kick queue for HITL. (facebookresearch#1931)
846f4e2
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc @dannymcy
Add dedicated kick queue for HITL. (facebookresearch#1931)
0559866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@zephirefaith zephirefaith Awaiting requested review from zephirefaith

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot