Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Allow empty user masks and add users to dependency injection container. #1932

Merged
merged 3 commits into from
May 2, 2024
Merged

HITL - Allow empty user masks and add users to dependency injection container. #1932

merged 3 commits into from
May 2, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented May 1, 2024

Motivation and Context

This changeset does the following:

  • Allow empty user masks.
  • Add users to the AppService dependency injection container.

This allows for code simplifications by removing lots of conditional networking logic and config reading.

How Has This Been Tested

Added unit test.

Types of changes

  • [Refactoring]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested review from jturner65, aclegg3 and zephirefaith May 1, 2024 00:39
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 1, 2024
aclegg3
aclegg3 approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0mdc 0mdc merged commit b293d80 into main May 2, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/empty_user_mask branch May 2, 2024 04:25
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@0mdc @dannymcy
HITL - Allow empty user masks and add users to dependency injection c…
9348b35 
…ontainer. (facebookresearch#1932)

* Allow 0 users in the Users class.

* Add users to dependency injection container.

* Formatting fix.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
HITL - Allow empty user masks and add users to dependency injection c…
ade5f04 
…ontainer. (facebookresearch#1932)

* Allow 0 users in the Users class.

* Add users to dependency injection container.

* Formatting fix.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc @dannymcy
HITL - Allow empty user masks and add users to dependency injection c…
f842b5a 
…ontainer. (facebookresearch#1932)

* Allow 0 users in the Users class.

* Add users to dependency injection container.

* Formatting fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@zephirefaith zephirefaith Awaiting requested review from zephirefaith

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot