Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HITL - Add configuration to control episode iterator by episode ID. #1935

Merged
merged 1 commit into from
May 2, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented May 1, 2024

Motivation and Context

This changes the rearrange_v2 config to allow to use the episode iterator by specifying episode IDs.

Without those changes, the episode iterator will occasionally select wrong episodes.

Thanks @Ram81 for finding this issue.

How Has This Been Tested

Tested on a large set of episodes.

Types of changes

  • [Bug Fix] (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested review from jturner65, aclegg3 and zephirefaith May 1, 2024 00:53
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 1, 2024
@0mdc 0mdc merged commit 9b29006 into main May 2, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/rearrangev2_iterator_fixes branch May 2, 2024 04:23
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants