Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unoccluded navmesh snap multiple ignores #1943

Merged
merged 2 commits into from
May 8, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 7, 2024

Motivation and Context

This PR refactors navmesh_utils to allow multiple object_id ignores in the "unoccluded snap" and accessibility utils.

This change has become more important with increased use of articulated objects and agents where the ignore list should include both the agent's body/links, the target object, and possibly additional links of a particular furniture asset.

How Has This Been Tested

Refactor should be mostly transparent beyond the conversion of inputs to lists. CI tests should satisfy.

Types of changes

  • [Refactoring] Large changes to the code that improve its functionality or performance
  • [Development] A pull request that add new features to the habitat-lab task and environment codebase. Development Pull Requests must be small (less that 500 lines of code change), have unit testing, very extensive documentation and examples. These are typically new tasks, environments, sensors, etc... The review process for these Pull Request is longer because these changes will be maintained by our core team of developers, so make sure your changes are easy to understand!

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 7, 2024
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aclegg3 aclegg3 merged commit 23796a6 into main May 8, 2024
3 of 4 checks passed
@aclegg3 aclegg3 deleted the alex-05_07-unoccluded_navmesh_snap_multiple_ignores branch May 8, 2024 15:43
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
* refactor navmesh_utils to allow a list of target_object_ids and correct some typos

* refactor downstream code to pass a list instead of a single int. Does not semantically address the expansion to multiple ids (e.g. for AOs).
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* refactor navmesh_utils to allow a list of target_object_ids and correct some typos

* refactor downstream code to pass a list instead of a single int. Does not semantically address the expansion to multiple ids (e.g. for AOs).
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* refactor navmesh_utils to allow a list of target_object_ids and correct some typos

* refactor downstream code to pass a list instead of a single int. Does not semantically address the expansion to multiple ids (e.g. for AOs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants