Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] - skip floor in KRM init #1948

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 13, 2024

Motivation and Context

KRM init from RearrangeEpisode should skip the "floor" receptacle string used to denote placement on the floor rather than in/on a Receptacle. No parenting relationships will result from this placement.

How Has This Been Tested

Added a test case for CI

Types of changes

  • [Bug Fix] (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@aclegg3 aclegg3 requested a review from rutadesai May 13, 2024 19:00
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 13, 2024
Copy link

@rutadesai rutadesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@aclegg3 aclegg3 merged commit 91f2f48 into main May 13, 2024
3 of 4 checks passed
@aclegg3 aclegg3 deleted the alex-05_13-skip_floor_in_krm_init branch May 13, 2024 21:00
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
* skip floor in KRM init. add a unit test
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* skip floor in KRM init. add a unit test
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* skip floor in KRM init. add a unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants