Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Add picture-in-picture viewports. #1958

Merged
merged 3 commits into from
May 17, 2024
Merged

HITL - Add picture-in-picture viewports. #1958

merged 3 commits into from
May 17, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented May 15, 2024

Motivation and Context

This changeset adds picture-in-picture viewports to the HITL app.

rearrange_v2 implements this by showing the other user's view in a multiplayer session.

viewports-2024-05-15_10.22.47.mp4

Notes

Depends on:

How Has This Been Tested

Tested in multiplayer HITL application.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 15, 2024
This was referenced May 15, 2024
Merged
Merged
@0mdc 0mdc mentioned this pull request May 17, 2024
Merged
5 tasks
aclegg3
aclegg3 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

habitat-hitl/habitat_hitl/core/client_message_manager.py Outdated Show resolved Hide resolved
@0mdc 0mdc force-pushed the 0mdc/hitl_viewports branch from a86541e to 114d41e Compare May 17, 2024 18:01
@0mdc 0mdc merged commit 31b8d0d into main May 17, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/hitl_viewports branch May 17, 2024 18:08
@0mdc 0mdc mentioned this pull request May 17, 2024
Merged
0mdc added a commit that referenced this pull request May 23, 2024
@0mdc
HITL - Add picture-in-picture viewports. (#1958)
783506e 
* Add viewports.

* Add viewports to rearrange_v2.

* Improve viewport rect description.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@0mdc @dannymcy
HITL - Add picture-in-picture viewports. (facebookresearch#1958)
1b655cd 
* Add viewports.

* Add viewports to rearrange_v2.

* Improve viewport rect description.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
HITL - Add picture-in-picture viewports. (facebookresearch#1958)
9075aa6 
* Add viewports.

* Add viewports to rearrange_v2.

* Improve viewport rect description.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc @dannymcy
HITL - Add picture-in-picture viewports. (facebookresearch#1958)
101aee5 
* Add viewports.

* Add viewports to rearrange_v2.

* Improve viewport rect description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@zephirefaith zephirefaith Awaiting requested review from zephirefaith

@Ram81 Ram81 Awaiting requested review from Ram81

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot