-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HITL - Decouple agents from users. #1972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
May 22, 2024
aclegg3
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Abstract the users as agents, allow an agent to be policy driven instead of GUI driven, and provide some APIs to differentiate the two.
0mdc
added a commit
that referenced
this pull request
May 23, 2024
* Add session management. * Formatting changes. * Add clarifications to episode resolution. * Document temporary hack to check for client-side loading status. * Add session recorder, ui events and data upload. * Add end episode form with error reporting. * Decouple agents from users. * Update agent camera transform from sensor. * Update comment.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jun 26, 2024
* Add session management. * Formatting changes. * Add clarifications to episode resolution. * Document temporary hack to check for client-side loading status. * Add session recorder, ui events and data upload. * Add end episode form with error reporting. * Decouple agents from users. * Update agent camera transform from sensor. * Update comment.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* Add session management. * Formatting changes. * Add clarifications to episode resolution. * Document temporary hack to check for client-side loading status. * Add session recorder, ui events and data upload. * Add end episode form with error reporting. * Decouple agents from users. * Update agent camera transform from sensor. * Update comment.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* Add session management. * Formatting changes. * Add clarifications to episode resolution. * Document temporary hack to check for client-side loading status. * Add session recorder, ui events and data upload. * Add end episode form with error reporting. * Decouple agents from users. * Update agent camera transform from sensor. * Update comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This changeset decouples the concept of 'user' and 'agent' in the
rearrange_v2
application to the application to be used by either human users or AIs.How Has This Been Tested
Tested locally.
Types of changes
Checklist