Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HITL - Decouple agents from users. #1972

Merged
merged 12 commits into from
May 22, 2024
Merged

HITL - Decouple agents from users. #1972

merged 12 commits into from
May 22, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented May 22, 2024

Motivation and Context

This changeset decouples the concept of 'user' and 'agent' in the rearrange_v2 application to the application to be used by either human users or AIs.

How Has This Been Tested

Tested locally.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 22, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Abstract the users as agents, allow an agent to be policy driven instead of GUI driven, and provide some APIs to differentiate the two.

@0mdc 0mdc merged commit 99d63ea into main May 22, 2024
4 checks passed
@0mdc 0mdc deleted the 0mdc/user_agent_decoupling branch May 22, 2024 20:56
0mdc added a commit that referenced this pull request May 23, 2024
* Add session management.

* Formatting changes.

* Add clarifications to episode resolution.

* Document temporary hack to check for client-side loading status.

* Add session recorder, ui events and data upload.

* Add end episode form with error reporting.

* Decouple agents from users.

* Update agent camera transform from sensor.

* Update comment.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
* Add session management.

* Formatting changes.

* Add clarifications to episode resolution.

* Document temporary hack to check for client-side loading status.

* Add session recorder, ui events and data upload.

* Add end episode form with error reporting.

* Decouple agents from users.

* Update agent camera transform from sensor.

* Update comment.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* Add session management.

* Formatting changes.

* Add clarifications to episode resolution.

* Document temporary hack to check for client-side loading status.

* Add session recorder, ui events and data upload.

* Add end episode form with error reporting.

* Decouple agents from users.

* Update agent camera transform from sensor.

* Update comment.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* Add session management.

* Formatting changes.

* Add clarifications to episode resolution.

* Document temporary hack to check for client-side loading status.

* Add session recorder, ui events and data upload.

* Add end episode form with error reporting.

* Decouple agents from users.

* Update agent camera transform from sensor.

* Update comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants