Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add human-readable display names to object states. #2005

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Aug 6, 2024

Motivation and Context

This adds user-facing strings for creating GUIs with boolean object states.

ui_action_change-2024-08-05_01.57.05.mp4

How Has This Been Tested

Tested in HITL applications.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested review from aclegg3 and MatthewChang August 6, 2024 16:46
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 6, 2024
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0mdc 0mdc merged commit 42e0a7a into main Aug 6, 2024
4 checks passed
@0mdc 0mdc deleted the 0mdc/object_states_display_names branch August 6, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants