Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] - remove unnecessary debug code #2007

Merged
merged 1 commit into from
Aug 13, 2024
Merged

[BE] - remove unnecessary debug code #2007

merged 1 commit into from
Aug 13, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 12, 2024

Motivation and Context

Removes some debug code encouraging use of wireframe object templates instead of debug_line_render for debugging utils.

How Has This Been Tested

NA

Types of changes

  • [Refactoring] Large changes to the code that improve its functionality or performance

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@aclegg3 aclegg3 requested a review from 0mdc August 12, 2024 16:10
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 12, 2024
0mdc
0mdc approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the clean-up!

@aclegg3 aclegg3 merged commit 06a5457 into main Aug 13, 2024
4 checks passed
@aclegg3 aclegg3 deleted the alex-08_12-be_remove_dead_code branch August 13, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @0mdc @facebook-github-bot