Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Add status API to availability server. #2023

Merged
merged 2 commits into from
Aug 21, 2024
Merged

HITL - Add status API to availability server. #2023

merged 2 commits into from
Aug 21, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Aug 20, 2024

Motivation and Context

This changeset adds a status API to the availability server to provide richer information for multiplayer matchmaking and live statistics.

How Has This Been Tested

Tested on distributed multiplayer HITL application.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested review from aclegg3 and eundersander August 20, 2024 22:21
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 20, 2024
eundersander
eundersander approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments about naming. Also it would be nice to see stub_client.html or some other test code updated to use this. Otherwise LGTM!

habitat-hitl/habitat_hitl/_internal/networking/networking_process.py Outdated Show resolved Hide resolved
habitat-hitl/habitat_hitl/_internal/networking/networking_process.py Outdated Show resolved Hide resolved
habitat-hitl/habitat_hitl/_internal/networking/networking_process.py Show resolved Hide resolved
@0mdc
Copy link
Contributor Author

0mdc commented Aug 21, 2024 •
edited
Loading

it would be nice to see stub_client.html or some other test code updated to use this

I'll submit a bunch of updates to stub_client.html separately. I've been using it extensively to work with the latest stack.

@0mdc 0mdc merged commit e5a233b into main Aug 21, 2024
1 of 3 checks passed
@0mdc 0mdc deleted the 0mdc/hitl_status_api branch August 21, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eundersander eundersander eundersander approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @eundersander @facebook-github-bot