Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] - cleanup docstring core.benchmark #2033

Merged
merged 3 commits into from
Aug 22, 2024
Merged

[BE] - cleanup docstring core.benchmark #2033

merged 3 commits into from
Aug 22, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 22, 2024

Motivation and Context

Add docstrings and typing for Benchmark class module.

How Has This Been Tested

CI and Daniel will check compiled docs.

Types of changes

  • [Docs change] Addition or changes to the documentation

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@aclegg3 aclegg3 requested a review from danieltmeta August 22, 2024 15:52
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 22, 2024
danieltmeta
danieltmeta approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@danieltmeta danieltmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring annotations approved.

@aclegg3 aclegg3 merged commit 2dd1497 into main Aug 22, 2024
4 checks passed
@aclegg3 aclegg3 deleted the daniel-07_04-cleanup_docstring_core_benchmark branch August 22, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieltmeta danieltmeta danieltmeta approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @danieltmeta @facebook-github-bot