Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HITL - Session Data Improvements #2044

Merged
merged 3 commits into from
Aug 28, 2024
Merged

HITL - Session Data Improvements #2044

merged 3 commits into from
Aug 28, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Aug 27, 2024

Motivation and Context

This changeset changes the data format of the HITL output to improve its functionality.
In this context, a "session" is a sequence of N episodes to be completed.

Instead of recording a single file for a session, the system now records a single file per episode, and a session metadata file. The following content is uploaded to S3:

output_{port}/
    {episode_id}.json.gz
    {episode_id}.json.gz
    session.json.gz

session_output

Changes:

  • Episodes are now recorded in individual files.
    • If the session fails (e.g. a user disconnects after completing some episodes), the completed episodes are uploaded.
  • A lightweight session.json.jz file is created for each session, even if there is no episode.
    • The session contains vital data such as errors and total time spent.
  • Data collection output is now structured.
  • Empty frames are now recorded.
  • Miscellaneous small improvements.

How Has This Been Tested

Tested on single-user and multi-user sessions.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 27, 2024
@0mdc 0mdc marked this pull request as ready for review August 27, 2024 15:07
Copy link
Contributor

@zephirefaith zephirefaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you for improving the logic here.
Nit about same naming of local and class variable to avoid confusion.

examples/hitl/rearrange_v2/session.py Show resolved Hide resolved
examples/hitl/rearrange_v2/app_state_load_episode.py Outdated Show resolved Hide resolved
@0mdc 0mdc merged commit b3e7672 into main Aug 28, 2024
3 of 4 checks passed
@0mdc 0mdc deleted the 0mdc/hitl_session_data branch August 28, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants