Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add receptacle filtering to rearrange_sim #2053

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 29, 2024

Motivation and Context

In the current paradigm, we expect to respect the Receptacle filter files from the dataset. This PR adds filtering by default to rearrange_sim

How Has This Been Tested

CI should verify that this change doesn't break unit tests, if so they should be adjusted.

Types of changes

  • [Refactoring] Large changes to the code that improve its functionality or performance

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 29, 2024
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm frequently seeing the warning Warning: No receptacle filter file found for scene {scene_id}, no filtering will be done!.

What happens in this case?

@aclegg3
Copy link
Contributor Author

aclegg3 commented Sep 3, 2024

LGTM!

I'm frequently seeing the warning Warning: No receptacle filter file found for scene {scene_id}, no filtering will be done!.

What happens in this case?

Let me know which scene this is and on which dataset version. It could be a missing configuration field or just stale data.

@aclegg3 aclegg3 merged commit 129e029 into main Sep 3, 2024
4 checks passed
@aclegg3 aclegg3 deleted the alex-08_29-filter_receptacles_rearrange_sim branch September 3, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants