HITL - Highlight default receptacles #2075
Conversation
facebook-github-bot
added
the
CLA Signed
| contextual_color = color_ui_valid | ||
| contextual_info.append( | ||
| ( | ||
| "Double-click to pick up.", |
There was a problem hiding this comment.
should this be color_ui_info?
There was a problem hiding this comment.
The color theme is the following:
- White: Generic information.
- Yellow: Anything related to a pickable object.
- Cyan: Selection.
- Green: Anything related to a possible action.
- Red: Anything related to an impossible action.
I made this label green to match with the green highlight that indicates that an object can be picked up.
selection_ui-2024-08-31_18.03.30.mp4
| @@ -696,20 +705,29 @@ def _update_selected_object_ui(self): | |||
| # Get the contextual information. | |||
| color_ui_valid = [0.2, 1.0, 0.2, 1.0] | |||
| color_ui_invalid = [1.0, 0.2, 0.2, 1.0] | |||
| color_ui_info = None | |||
| color_ui_object_info = [0.8, 0.8, 0.2, 1.0] | |||
There was a problem hiding this comment.
hm maybe we should only have color_ui_info and use it in all places? rather than have color_ui_info and color_ui_object_info?
There was a problem hiding this comment.
Also let;s make these the same as the colors defined at the top of this file, rather than re-define them here?
There was a problem hiding this comment.
Also let;s make these the same as the colors defined at the top of this file, rather than re-define them here?
I'll refactor that in a later pass.
- Those 2 colors are in different formats. This will be unified.
- The contextual information duplicates the real checks. This will be unified.
There was a problem hiding this comment.
hm maybe we should only have color_ui_info and use it in all places? rather than have color_ui_info and color_ui_object_info?
I think that it's preferable to have contextual information related to pickable objects yellow, like the pickable object highlights.
| not in self._world._opened_link_set | ||
| ): | ||
| color_default_link = self._to_color_array( | ||
| COLOR_HIGHLIGHT |
There was a problem hiding this comment.
I think ok for now, but maybe in the future, should be a config variable?
There was a problem hiding this comment.
Agreed!
I introduced UI configuration in this PR. I intend to make it fully configurable in the following weeks.
Motivation and Context
This changeset adds a contextual UI that shows the default receptacle.
The following changes are included:
default_receptacle-2024-09-07_12.58.27.mp4
How Has This Been Tested
Tested on HITL application.
Types of changes
Checklist