Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modern gym environment usage #498

Merged
merged 5 commits into from
Oct 14, 2020
Merged

Allow modern gym environment usage #498

merged 5 commits into from
Oct 14, 2020

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

It solves #64 and #460 by updating the gym interface to one that is backward and forward compatible. This should remove the need to pin gym versions.

How Has This Been Tested

  • Locally by ensuring that all the new import paths work. Everything from the top level __init__ packages is pretty stable between versions so just using those imports works across modern versions.

Types of changes

  • refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 13, 2020
@Skylion007 Skylion007 changed the title Allow modern gym environmnet usage Allow modern gym environment usage Oct 13, 2020
@Skylion007
Copy link
Contributor Author

Fixes #498 #460 #64 #497

@Skylion007 Skylion007 merged commit 7c42866 into master Oct 14, 2020
@Skylion007 Skylion007 deleted the gym_import_fixes branch October 14, 2020 17:00
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* Allow modern gym environmnet usage

* Fix habitat_sim typing imports

* Fix shebang

* Explicitly upgrade gym

* Minor bugfixes
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
* Allow modern gym environmnet usage

* Fix habitat_sim typing imports

* Fix shebang

* Explicitly upgrade gym

* Minor bugfixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants