--[Bug Fix] Address out of date config file extensions. #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jturner65
changed the title
facebook-github-bot
added
the
CLA Signed
jturner65
force-pushed
the
MM_Config_Bugfix
branch
2 times, most recently
from
024aab7 to
2075580
Compare
jturner65
changed the title
jturner65
force-pushed
the
MM_Config_Bugfix
branch
from
2075580 to
4830782
Compare
jturner65
force-pushed
the
MM_Config_Bugfix
branch
from
4830782 to
b1d5589
Compare
6 tasks
Skylion007
approved these changes
Oct 21, 2020
|
If it passes, merge it in. |
|
What is causing this timeout? It happens pretty often on sim as well :(. |
|
Can you link logs? All the force pushing is covering up which runs actually timed out. |
|
There is a pytest timeout that says no test can take more than 10 minutes. That can be changed in settings. |
|
It seems arbitrary - sometimes it times out, sometimes it does not. The most recent was the one that just failed. |
srama2512
pushed a commit
that referenced
this pull request
Mar 15, 2023
This test was not compiling on my machine due to sqrt() returning a double and then passing that to Vector3 initializer list. Using builtin Magnum constants for that instead, plus constructing the vector in a single step.
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
--[Bug Fix] Address out of date config file extensions.
HHYHRHY
pushed a commit
to SgtVincent/EMOS
that referenced
this pull request
Aug 31, 2024
--[Bug Fix] Address out of date config file extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Updates Hab-Lab to be compatible with recent Hab-Sim breaking changes :
facebookresearch/habitat-sim#869
How Has This Been Tested
Types of changes
x- Bug fix (non-breaking change which fixes an issue)
Checklist