-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hab tasks fix #684
Merged
Merged
Hab tasks fix #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cking task to work.
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Jul 12, 2021
mathfac
approved these changes
Jul 13, 2021
srama2512
pushed a commit
that referenced
this pull request
Mar 15, 2023
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
Critical fixes for the Habitat 2.0 pick task. This PR fixes all the issues to make the Pick task actually work as detailed in the Habitat 2.0 paper.
HHYHRHY
pushed a commit
to SgtVincent/EMOS
that referenced
this pull request
Aug 31, 2024
Critical fixes for the Habitat 2.0 pick task. This PR fixes all the issues to make the Pick task actually work as detailed in the Habitat 2.0 paper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
On master there are critical bugs in the Habitat 2.0 pick task. While the task is runnable, many things don’t work at all (described in the changes section). This PR fixes all the issues to make the Pick task actually work as detailed in the Habitat 2.0 paper.
This PR is blocked by this Habitat Sim PR: facebookresearch/habitat-sim#1373
How Has This Been Tested
With
test_rearrange_task.py
. Also with the newly added interactive play script which is run asThis allows the user to manually control the robot. Using this, I verified all aspects of the picking task work. I tried various scenarios such as picking up the correct object, wrong object, picking up no object, colliding with the scene, etc.
Types of changes
Critical fixes:
Non-critical fixes:
Still TODO fixes which will be included in this PR.
Example of interactive play script:
vid.mov
Checklist