Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--Update field name to match Habitat-Sim refactor. #731

Merged
merged 1 commit into from
Sep 21, 2021
Merged

--Update field name to match Habitat-Sim refactor. #731

merged 1 commit into from
Sep 21, 2021

Conversation

jturner65
Copy link
Contributor

Motivation and Context

Tiny refactor to support this change in Habitat-Sim. Field name is changed, and value is inverted to reflect meaning.

How Has This Been Tested

Locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 20, 2021
@jturner65 jturner65 mentioned this pull request Sep 20, 2021
Merged
11 tasks
@jturner65 jturner65 requested a review from aclegg3 September 20, 2021 19:12
@jturner65 jturner65 merged commit 9e53a17 into facebookresearch:master Sep 21, 2021
@jturner65 jturner65 deleted the requires_lighting_refactor branch September 21, 2021 19:24
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@jturner65
Merge pull request facebookresearch#731 from jturner65/requires_light…
741b3c8 
…ing_refactor

--Update field name to match Habitat-Sim refactor.
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
@jturner65
Merge pull request facebookresearch#731 from jturner65/requires_light…
042770b 
…ing_refactor

--Update field name to match Habitat-Sim refactor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwijmans erikwijmans erikwijmans approved these changes

@mathfac mathfac Awaiting requested review from mathfac

@Skylion007 Skylion007 Awaiting requested review from Skylion007

@aclegg3 aclegg3 Awaiting requested review from aclegg3

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jturner65 @erikwijmans @facebook-github-bot