Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flake suggestions and combined logical clauses. #732

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

mathfac
Copy link
Contributor

@mathfac mathfac commented Sep 21, 2021

Motivation and Context

Fixed flake suggestions and combined logical clauses. Should fix CI. Most probably new version of flake8 is smarter now

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 21, 2021
@mathfac mathfac merged commit c572935 into master Sep 21, 2021
@mathfac mathfac deleted the fix_flake branch September 21, 2021 20:22
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
…ch#732)

Fixed flake suggestions and combined logical clauses.
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
…ch#732)

Fixed flake suggestions and combined logical clauses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants