Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed references from master to main in docs and for DDPPO master address #748

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Renamed references from master to main in docs and for DDPPO master address #748

merged 1 commit into from
Oct 12, 2021

Conversation

mathfac
Copy link
Contributor

@mathfac mathfac commented Oct 12, 2021 •
edited
Loading

Motivation and Context

To support master => main renaming github wide: Renamed references from master to main in docs and for DDPPO master address.

Warning: training scripts may stop working you may need to export MASTER_ADDR=$(srun --ntasks=1 hostname 2>&1 | tail -n1) to export MAIN_ADDR=$(srun --ntasks=1 hostname 2>&1 | tail -n1)

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mathfac mathfac merged commit 22024c1 into main Oct 12, 2021
@mathfac mathfac deleted the master_renamed branch October 12, 2021 21:14
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 12, 2021
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@mathfac
Renamed references from master to main in docs and for DDPPO master a…
1747cc8 
…ddress (facebookresearch#748)

To support master => main renaming github wide: Renamed references from master to main in docs and for DDPPO master address.

Warning: training scripts may stop working you may need to export MASTER_ADDR=$(srun --ntasks=1 hostname 2>&1 | tail -n1) to export MAIN_ADDR=$(srun --ntasks=1 hostname 2>&1 | tail -n1)
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
@mathfac
Renamed references from master to main in docs and for DDPPO master a…
4e54bce 
…ddress (facebookresearch#748)

To support master => main renaming github wide: Renamed references from master to main in docs and for DDPPO master address.

Warning: training scripts may stop working you may need to export MASTER_ADDR=$(srun --ntasks=1 hostname 2>&1 | tail -n1) to export MAIN_ADDR=$(srun --ntasks=1 hostname 2>&1 | tail -n1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwijmans erikwijmans erikwijmans approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

@ykarmesh ykarmesh Awaiting requested review from ykarmesh

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mathfac @Skylion007 @erikwijmans @facebook-github-bot