Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Showing the mypy version on circleci tests #798

Merged
merged 1 commit into from
Jan 25, 2022
Merged

[CI] Showing the mypy version on circleci tests #798

merged 1 commit into from
Jan 25, 2022

Conversation

vincentpierre
Copy link
Contributor

Motivation and Context

For consistency and reproducibility, the version of mypy will be displayed in circleci when the test fails. This will help the developer reproduce the mypy errors and is consistent with the way the isort and flake8 tests are organized.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vincentpierre vincentpierre requested a review from mathfac January 25, 2022 00:19
@vincentpierre vincentpierre self-assigned this Jan 25, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 25, 2022
@vincentpierre vincentpierre merged commit 3365492 into facebookresearch:main Jan 25, 2022
@vincentpierre vincentpierre deleted the mypy_show_version branch January 25, 2022 19:51
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@vincentpierre
showing the mypy version for local reproducibility (facebookresearch#798
863632a 
)

Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
@vincentpierre
showing the mypy version for local reproducibility (facebookresearch#798
ff1a12e 
)

Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@mathfac mathfac Awaiting requested review from mathfac

Assignees

@vincentpierre vincentpierre

Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincentpierre @Skylion007 @facebook-github-bot