Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci-bugfix] - remove opencv conda #886

Merged
merged 6 commits into from
Jun 14, 2022
Merged

[ci-bugfix] - remove opencv conda #886

merged 6 commits into from
Jun 14, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jun 13, 2022

Motivation and Context

installing both conda opencv and pip opencv-python was redundant and causing package conflicts on CI. Removing the conda install in favor of the pip install defined in requirements.txt.

How Has This Been Tested

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from Skylion007 June 13, 2022 23:15
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 13, 2022
@aclegg3 aclegg3 mentioned this pull request Jun 13, 2022
Closed
7 tasks
@aclegg3 aclegg3 merged commit fedcfdc into main Jun 14, 2022
@aclegg3 aclegg3 deleted the remove-opencv-conda-no-downgrade branch June 14, 2022 14:49
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@aclegg3
[ci-bugfix] - remove opencv conda (facebookresearch#886)
35ca857
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
@aclegg3
[ci-bugfix] - remove opencv conda (facebookresearch#886)
b860c6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @Skylion007 @facebook-github-bot