Added Franka blockstacking example #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
1heart
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Overall lgtm, minor nits:
- Very similarly to the prior PR involving
franka_example.py, it would be nice to (1) isolate the output of argparse from the function itself, (2) avoid the double negativenot args.no_render. - You could also import functions
display_grayscale,display_rgbrelatively there, to avoid duplication. - Add a screenshot of this working.
|
Can this run, without rendering as a unit test for test_examples. See https://github.com/facebookresearch/habitat-lab/blob/main/test/test_examples.py for how to hook up the script. |
aclegg3
reviewed
Aug 24, 2022
aclegg3
reviewed
Aug 26, 2022
mathfac
approved these changes
Aug 30, 2022
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* added franka blockstacking example * pulled display util funcs out, cleaned arg parsing * updated block example * add franka blockstack to tests * download pointnav data in circleci * fix indentation in circleci config * download data after installing habitat-sim api * conda activate before habitat-sim * restore circleci config * use symlink data to habitat sim * add data path change * use cubeSolid handle * download panda arm urdf in ci tests * update circleci config to match main * use constants * use constants for range offset
HHYHRHY
pushed a commit
to SgtVincent/EMOS
that referenced
this pull request
Aug 31, 2024
* added franka blockstacking example * pulled display util funcs out, cleaned arg parsing * updated block example * add franka blockstack to tests * download pointnav data in circleci * fix indentation in circleci config * download data after installing habitat-sim api * conda activate before habitat-sim * restore circleci config * use symlink data to habitat sim * add data path change * use cubeSolid handle * download panda arm urdf in ci tests * update circleci config to match main * use constants * use constants for range offset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Creates a new franka blockstacking example using the static manipulator class.
T122948310
How Has This Been Tested
Running the example (with a display) succeeds in creating an environment with 6 blocks that can be manipulated
DISPLAY=:100 python examples/franka_blockstacking_example.pyTypes of changes
Checklist