Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README needed some dusting and cleanup #927

Merged
merged 5 commits into from
Aug 19, 2022
Merged

README needed some dusting and cleanup #927

merged 5 commits into from
Aug 19, 2022

Conversation

dhruvbatra
Copy link
Contributor

  • moving details out to another file
  • updating readme

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Dhruv Batra added 2 commits August 13, 2022 16:21
 interactive rebase in progress; onto e074ef8
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 14, 2022
@dhruvbatra dhruvbatra requested a review from mathfac August 14, 2022 01:43
@@ -170,7 +170,7 @@ SIMULATOR:
DEFAULT_AGENT_ID: 0
FORWARD_STEP_SIZE: 0.25
HABITAT_SIM_V0:
ALLOW_SLIDING: False
ALLOW_SLIDING: True
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ASzot -- you okay with this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a good idea.

README.md Outdated Show resolved Hide resolved

* `Dataset`: contains a list of task-specific episodes from a particular data split and additional dataset-wide information. Handles loading and saving of a dataset to disk, getting a list of scenes, and getting a list of episodes for a particular scene.
# Interactive play script
python examples/interactive_play.py --never-end --add-ik
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python examples/interactive_play.py --never-end --add-ik
python examples/interactive_play.py --never-end

I think by default no ik so people don't have to install PyBullet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried playing around with both. It's very hard to control the arm without IK. Why the hesitation to pip install pybullet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an additional command they need to run to get things working, but I agree it's not a big deal to install pybullet.

Co-authored-by: Andrew Szot <ASzot@users.noreply.github.com>
@dhruvbatra dhruvbatra merged commit c4d80a1 into main Aug 19, 2022
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* moving details out to another file

 interactive rebase in progress; onto 4051c1a

* updating readme

* adding pygame hab 2.0 visualization

* turning base sliding on for interactive play; makes user-control easier

* Update README.md

Co-authored-by: Andrew Szot <ASzot@users.noreply.github.com>

Co-authored-by: Dhruv Batra <dbatra@fb.com>
Co-authored-by: Andrew Szot <ASzot@users.noreply.github.com>
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
* moving details out to another file

 interactive rebase in progress; onto e074ef8

* updating readme

* adding pygame hab 2.0 visualization

* turning base sliding on for interactive play; makes user-control easier

* Update README.md

Co-authored-by: Andrew Szot <ASzot@users.noreply.github.com>

Co-authored-by: Dhruv Batra <dbatra@fb.com>
Co-authored-by: Andrew Szot <ASzot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants