Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing mypy issue on main due to merge conflict #932

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Fixing mypy issue on main due to merge conflict #932

merged 1 commit into from
Aug 24, 2022

Conversation

vincentpierre
Copy link
Contributor

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vincentpierre vincentpierre requested a review from ykarmesh August 24, 2022 21:42
@vincentpierre vincentpierre self-assigned this Aug 24, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 24, 2022
@vincentpierre vincentpierre merged commit 9c92cde into facebookresearch:main Aug 24, 2022
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@vincentpierre
Fixing mypy issue on main due to merge conflict (facebookresearch#932)
54941a4 
Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
@vincentpierre
Fixing mypy issue on main due to merge conflict (facebookresearch#932)
fe8360e 
Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykarmesh ykarmesh ykarmesh approved these changes

Assignees

@vincentpierre vincentpierre

Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincentpierre @ykarmesh @facebook-github-bot