Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] [Rearrange] Reset the sensors positons correctly version 2 #952

Conversation

vincentpierre
Copy link
Contributor

@vincentpierre vincentpierre commented Sep 20, 2022

Motivation and Context

This is an alternative fix for #949
In this version, instead of updating the robot in the first observation, we reset the robot manually in each task reset.
This is potentially cleaner since there is no need to change _get_observations but it requires adding a method call in all existing (an future) reset calls of classes that implement the RearrangeTaskv1 class.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vincentpierre vincentpierre self-assigned this Sep 20, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 20, 2022
@vincentpierre vincentpierre added the bug Something isn't working label Sep 20, 2022
@aclegg3
Copy link
Contributor

aclegg3 commented Sep 21, 2022

IMO this is the cleaner option. Once sensor redesign is done and robot sensor attachment is refactored, this can hopefully be removed anyway.

@vincentpierre vincentpierre merged commit e822dce into facebookresearch:main Sep 22, 2022
ASzot pushed a commit that referenced this pull request Oct 3, 2022
…952)

Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
…acebookresearch#952)

Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
…acebookresearch#952)

Co-authored-by: vincentpierre <vincentpierre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants