Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] - add mp3d_example scene dataset config to the tutorials #1847

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 30, 2022

Motivation and Context

We previously removed backwards compatibility for some MP3D automated configuration. The colab tutorials need to be updated to reference the SceneDataset config files in order to correctly orient the semantic mesh asset.

See #1756

How Has This Been Tested

CI and locally running the tutorials

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 30, 2022
@aclegg3 aclegg3 merged commit a0061df into main Aug 30, 2022
@aclegg3 aclegg3 deleted the eccv-tutorial-add-mp3d-dataset branch August 30, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants