Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] - add spot robot assets to CI test set #2201

Merged
merged 1 commit into from
Sep 11, 2023
Merged

[CI] - add spot robot assets to CI test set #2201

merged 1 commit into from
Sep 11, 2023

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Sep 11, 2023

Motivation and Context

CI lab test is failing due to missing test asset required by changes in facebookresearch/habitat-lab#1543. Adding that asset appears to resolve the issue.

Thanks @ASzot for the suggested fix.

How Has This Been Tested

CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 11, 2023
jimmytyyang
jimmytyyang approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@jimmytyyang jimmytyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aclegg3 aclegg3 merged commit f83e738 into main Sep 11, 2023
1 check passed
@aclegg3 aclegg3 deleted the add-test-resources branch September 11, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@jimmytyyang jimmytyyang jimmytyyang approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aclegg3 @jimmytyyang @0mdc @facebook-github-bot