Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange Task Config Cleanup #1543

Merged
merged 16 commits into from
Sep 6, 2023
Merged

Rearrange Task Config Cleanup #1543

merged 16 commits into from
Sep 6, 2023

Conversation

ASzot
Copy link
Contributor

@ASzot ASzot commented Aug 27, 2023

Motivation and Context

  • Refactored config scheme for Habitat-Lab rearrange tasks. Now everything is defined under habitat/benchmark/rearrange. Everything needed to configure a task is now in one config file. From a task config like habitat/config/benchmark/rearrange/skills/pick.yaml you can easily change the (1) sensor suite, (2) robot type, (3) action space, (4) dataset. Everything about the task is defined in this one file and there are no hidden configs.
  • Refactored terminology of Composite (old name that is outdated) to Pddl.
  • Removed unused PDDL code.
  • New tests for PDDL code.

How Has This Been Tested

New tests and end-to-end training.

Types of changes

  • [Refactoring] Large changes to the code that improve its functionality or performance
  • [Development] A pull request that add new features to the habitat-lab task and environment codebase. Development Pull Requests must be small (less that 500 lines of code change), have unit testing, very extensive documentation and examples. These are typically new tasks, environments, sensors, etc... The review process for these Pull Request is longer because these changes will be maintained by our core team of developers, so make sure your changes are easy to understand!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 27, 2023
@ASzot ASzot requested a review from xavierpuigf August 28, 2023 17:14
Copy link
Contributor

@xavierpuigf xavierpuigf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good! I don't see an important case that we would be missing with this. Thanks for the PR!

@xavierpuigf xavierpuigf merged commit 89c970d into main Sep 6, 2023
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
* Refactor

* Pre commit

* Remove debug

* CI test

* CI?

* fixes

* Update test_baseline_training.py

* Update test_baseline_training.py

* Update test_baseline_training.py

* Update test_baselines_hydra.py

* Update test_baseline_training.py

* update pddl_sensor error

* update keys obs

* config fix

* update bench

* update bench sh

---------

Co-authored-by: Xavier Puig <xavierpuigf@gmail.com>
HHYHRHY pushed a commit to SgtVincent/EMOS that referenced this pull request Aug 31, 2024
* Refactor

* Pre commit

* Remove debug

* CI test

* CI?

* fixes

* Update test_baseline_training.py

* Update test_baseline_training.py

* Update test_baseline_training.py

* Update test_baselines_hydra.py

* Update test_baseline_training.py

* update pddl_sensor error

* update keys obs

* config fix

* update bench

* update bench sh

---------

Co-authored-by: Xavier Puig <xavierpuigf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants