-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearrange Task Config Cleanup #1543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierpuigf
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good! I don't see an important case that we would be missing with this. Thanks for the PR!
11 tasks
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* Refactor * Pre commit * Remove debug * CI test * CI? * fixes * Update test_baseline_training.py * Update test_baseline_training.py * Update test_baseline_training.py * Update test_baselines_hydra.py * Update test_baseline_training.py * update pddl_sensor error * update keys obs * config fix * update bench * update bench sh --------- Co-authored-by: Xavier Puig <xavierpuigf@gmail.com>
HHYHRHY
pushed a commit
to SgtVincent/EMOS
that referenced
this pull request
Aug 31, 2024
* Refactor * Pre commit * Remove debug * CI test * CI? * fixes * Update test_baseline_training.py * Update test_baseline_training.py * Update test_baseline_training.py * Update test_baselines_hydra.py * Update test_baseline_training.py * update pddl_sensor error * update keys obs * config fix * update bench * update bench sh --------- Co-authored-by: Xavier Puig <xavierpuigf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
habitat/benchmark/rearrange
. Everything needed to configure a task is now in one config file. From a task config likehabitat/config/benchmark/rearrange/skills/pick.yaml
you can easily change the (1) sensor suite, (2) robot type, (3) action space, (4) dataset. Everything about the task is defined in this one file and there are no hidden configs.Composite
(old name that is outdated) toPddl
.How Has This Been Tested
New tests and end-to-end training.
Types of changes