Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Assorted ~10kLOC update containing mainly various prerequisites for the batch renderer, and additions to Python bindings.
GL::Buffer
andGL::Mesh
internals -- it used to take 48 bytes per mesh attribute, now it's just 24. It also no longer does nasty voodoo with in-place construction of astd::vector
.magnum-sceneconverter --remove-duplicate-materials
option as well, and it's in the materialtools Python bindings too. In practice it will need a material canonicalization utility (such as removing empty layers, redundant default attributes and such) to truly remove all duplicates, that's coming next.Oh, and I made Utility::String::lowercase() >10x faster while being idle on the weekly call, and then 2x more using AVX2, so ~25x faster. See mosra/corrade@8085201 and mosra/corrade@8010c5c...d40ff9d for details, the "naive" case below is the previous implementation.
How Has This Been Tested
💚