Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[BE Week] Better Attributes Handle search efficiency; Viewer.cpp/Viewer.py text render fixes #2279

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Dec 11, 2023

Motivation and Context

This PR leverages the recent updates to our Magnum libs to address some inefficiencies and bugs, and fixes a minor bug with how scene instances were being loaded.

Viewer.cpp/Viewer.py :

  1. Improve text rendering in the viewers by using the magnum's new glyph handling.
  2. Fix the black-box background around text in viewer.py by enabling, defining and subsequently disabling the appropriate blend state when text is being drawn.

Attributes

  1. Speed up string handle match search by checking size of target string before forcing it to lowercase
  2. Add missing Articulated Object Attributes verification on Scene Instance load to be consistent with Stage, Object and Lighting Attributes handling.

How Has This Been Tested

Locally all tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 11, 2023
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -61,7 +61,7 @@ ObjectAttributesManager::createPrimBasedAttributesTemplate(
} // ObjectAttributesManager::createPrimBasedAttributesTemplate

void ObjectAttributesManager::createDefaultPrimBasedAttributesTemplates() {
this->undeletableObjectNames_.clear();
// this->undeletableObjectNames_.clear();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to remove this line.

@jturner65 jturner65 merged commit d46492a into main Dec 12, 2023
10 checks passed
@jturner65 jturner65 deleted the BE_AttributeHandleSearchEfficiency branch December 12, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants