Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--Properly initialize std::vector member variable to be correct size #2388

Merged
merged 1 commit into from
May 8, 2024
Merged

--Properly initialize std::vector member variable to be correct size #2388

merged 1 commit into from
May 8, 2024

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This bugfix fixes the incorrect initialization of the SceneNode semanticIDs_ vector which was causing a heap corruption.

How Has This Been Tested

Local c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 8, 2024
@jturner65 jturner65 requested review from 0mdc and aclegg3 May 8, 2024 09:21
0mdc
0mdc approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaky! Let's see if this solves the CI issue.

@0mdc 0mdc mentioned this pull request May 8, 2024
Merged
5 tasks
@jturner65 jturner65 merged commit 0792ef5 into main May 8, 2024
9 of 10 checks passed
@jturner65 jturner65 deleted the bugfix_sceneNodeIDVector branch May 8, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jturner65 @0mdc @facebook-github-bot