Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python3.10 on main branch #2166

Closed

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Apr 21, 2022

  • The most significant change is to hydra/core/plugins.py; the previous strategy used for importing plugins was causing a DeprecationWarning when I tested locally on Python3.10.
  • Our ray launcher does not support python3.10 (as the ray library on which it depends only works with <= 3.9). The CI for ray+py3.10 is "passing" (i.e. it is green) but the ray tests are not actually running.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2022
@Jasha10 Jasha10 force-pushed the i1856_python3.10_support branch 5 times, most recently from d143942 to ebdcfb0 Compare April 22, 2022 19:22
@Jasha10
Copy link
Collaborator Author

Jasha10 commented Apr 23, 2022

The CI seems to be working now except for the nevergrad plugin tests on Python3.10 + macOs/Linux, which fails during the pip installation of numpy.

@Jasha10 Jasha10 force-pushed the i1856_python3.10_support branch from ebdcfb0 to 78154e7 Compare April 25, 2022 21:14
@Jasha10 Jasha10 force-pushed the i1856_python3.10_support branch from 129416d to b9544f1 Compare April 28, 2022 21:14
@Jasha10 Jasha10 mentioned this pull request Apr 28, 2022
@Jasha10
Copy link
Collaborator Author

Jasha10 commented Apr 28, 2022

I'm closing this PR in favor of #2183; this PR's plugin tests will not run (issue #2181).

@Jasha10 Jasha10 closed this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants