Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.10 #2183

Merged
merged 1 commit into from
May 3, 2022
Merged

Support Python 3.10 #2183

merged 1 commit into from
May 3, 2022

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Apr 28, 2022 •
edited
Loading

To work around issue #2181, this PR is based on a branch of the hydra repo (not based on a fork).
Supersedes PR #2166.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 28, 2022
@Jasha10 Jasha10 mentioned this pull request Apr 28, 2022
Closed
@Jasha10
Copy link
Collaborator Author

Jasha10 commented Apr 28, 2022

From the circleci "trigger_plugin_pipelines" job:

AssertionError: Unexpected response while submitting CIRCLECI job for plugins. Response: {'message': 'Project not found'}

@Jasha10 Jasha10 force-pushed the i1856_python3.10_support branch from 1200c07 to a225c7b Compare May 3, 2022 19:19
@Jasha10 Jasha10 marked this pull request as ready for review May 3, 2022 20:14
@Jasha10
Copy link
Collaborator Author

Jasha10 commented May 3, 2022

All plugin CI jobs are enabled for Python3.10 except for the nevergrad sweeper tests.

@Jasha10 Jasha10 requested review from jieru-hu and pixelb May 3, 2022 20:16
jieru-hu
jieru-hu approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@jieru-hu jieru-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉

pixelb
pixelb approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@pixelb pixelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic!

@Jasha10 Jasha10 merged commit 277ff54 into main May 3, 2022
@Jasha10 Jasha10 deleted the i1856_python3.10_support branch May 3, 2022 21:25
@Jasha10 Jasha10 linked an issue May 3, 2022 that may be closed by this pull request
[Feature Request] Support python 3.10 #1856
Closed
@Jasha10 Jasha10 mentioned this pull request Jan 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieru-hu jieru-hu jieru-hu approved these changes

@pixelb pixelb pixelb approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support python 3.10
4 participants
@Jasha10 @pixelb @jieru-hu @facebook-github-bot