This repository has been archived by the owner on May 6, 2024. It is now read-only.
Eric/add converter #315
Merged
Eric/add converter #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cdmatters
force-pushed
the
eric/add-converter
branch
3 times, most recently
from
998e1e8
to
9e1e973
Compare
py::array::ensure attempts to convert an object to python array, if it already isn't one. Our use case wants to fail instead of create a new array, so instead we check py::isinstance. We also improved the error messages and remove the TODO for that.
Note that this involves changing the type of cursor entries from uint16 to unsigned char. Tests ported across, and the `reader` executable.
Taken from github.com:deadpixi/libtmt commit (1da7ba9).
…ange. This is a commit from interal research repo (cabeefb).
NetHack allows you to use the DEC graphics set to render the dungeon (https://nethackwiki.com/wiki/DECgraphics). Since DEC graphics mode is toggled on and off with ESC ( 0, ESC ( B respectively, we add a new 'state' to tmt to indicate when ESC ( have been pressed. Normally anything following this sequence is ignored, anyway. Each character then saves whether it was written in DEC mode or not, in attributes. While this would not work for a general DEC parser (since some DEC characters include whitespace/new lines etc that would not have been interpretted correctly by the terminal emulator - cf https://en.wikipedia.org/wiki/DEC_Special_Graphics) in this case this is fine because NetHack only uses DEC graphics for rendering particular glyphs (as suggested in the NetHack Wiki, and as suggested in paxed/dgamelaunch scriptfor stripping gfx). A test is added to check rendering.
cdmatters
force-pushed
the
eric/add-converter
branch
from
9e1e973
to
59037f4
Compare
tscmoo
approved these changes
Apr 27, 2022
|
So many tests, this looks great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the state of the internal
mainbranch when Heiner left. Everything so far has been reviewed internally.The key feature here is to add a ttyrec converter in C++.
It involves committing the a version of libtmt, which has been modified, and undergoes some changes.
See commits for more details.