Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Eric/add converter #315

Merged
merged 11 commits into from
Apr 28, 2022
Merged

Eric/add converter #315

merged 11 commits into from
Apr 28, 2022

Commits on Apr 14, 2022

  1. Commit original converter files from original dataset in hackrl repo.

    @cdmatters
    cdmatters committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    c12bde9 View commit details
    Browse the repository at this point in the history

  2. Refactor CMakeLists.txt to make tmt a separate library.

    @cdmatters
    cdmatters committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    451fb98 View commit details
    Browse the repository at this point in the history

  3. Add CMake to build the converter library.

    @cdmatters
    cdmatters committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    7b41d8d View commit details
    Browse the repository at this point in the history

  4. Add flags for clean compile and fixup.

    @cdmatters
    cdmatters committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    3d09904 View commit details
    Browse the repository at this point in the history

  5. Bump pytest version, add memory-profiler.

    @cdmatters
    cdmatters committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    19047f5 View commit details
    Browse the repository at this point in the history

  6. Fix bug in checked conversion. 

    py::array::ensure attempts to convert an object to python array, if
it already isn't one. Our use case wants to fail instead of create a
new array, so instead we check py::isinstance. We also improved the
error messages and remove the TODO for that.
    @cdmatters
    cdmatters committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    0151c87 View commit details
    Browse the repository at this point in the history

  7. Reimplement the ttyrecs.pyx converter in pybind11. 

    Note that this involves changing the type of cursor entries from uint16
to unsigned char. Tests ported across, and the `reader` executable.
    @cdmatters
    cdmatters committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    102410a View commit details
    Browse the repository at this point in the history

  8. Commit of libtmt into source. 

    Taken from github.com:deadpixi/libtmt commit (1da7ba9).
    @cdmatters
    cdmatters committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    567e1e8 View commit details
    Browse the repository at this point in the history

  9. (@heiner) Modify libtmt to not handle wide characters. Undo locale ch… 

    …ange.

This is a commit from interal research repo (cabeefb).
    @cdmatters
    cdmatters committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    d0d27d4 View commit details
    Browse the repository at this point in the history

  10. Add support for DEC graphic set from NetHack. 

    NetHack allows you to use the DEC graphics set to render the dungeon
(https://nethackwiki.com/wiki/DECgraphics). Since DEC graphics mode is
toggled on and off with ESC ( 0, ESC ( B respectively, we add a new
'state' to tmt to indicate when ESC ( have been pressed. Normally
anything following this sequence is ignored, anyway.

Each character then saves whether it was written in DEC mode or not, in
attributes. While this would not work for a general DEC parser (since
some DEC characters include whitespace/new lines etc that would not have
been interpretted correctly by the terminal emulator - cf
https://en.wikipedia.org/wiki/DEC_Special_Graphics) in this case this
is fine because NetHack only uses DEC graphics for rendering particular
glyphs (as suggested in the NetHack Wiki, and as suggested in paxed/dgamelaunch
scriptfor stripping gfx).

A test is added to check rendering.
    @cdmatters
    cdmatters committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    c068fab View commit details
    Browse the repository at this point in the history

  11. Make converter statically linked, instead of dynamically.

    @cdmatters
    cdmatters committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    59037f4 View commit details
    Browse the repository at this point in the history