-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 ci: setup deployment environments #102
Conversation
* fix: 🐛 patch removing pull_request.closed bug on metadata pr merge * fix: 🐛 don't update firstPublished in the codemeta file + better logs * fix: 🐛 patch error on reading db entry when it doesn't exist * chore: 🔊 better log on successful Zenodo publish * style: 🎨 margins between text and icon * feat: ✨ links to the list of tools used for codefair in /codefair * refactor: ✨ ♻️ abstract the license validation fn * doc: 🔖 update changelog * feat: ✨ ♻️ abstraction to zenodo workflow * wip: 🚧 abstracting zenodo workflow * feat: ✨ add help link in the Zenodo release page * refactor: ♻️ ✨ abstract out github release functions * refactor: 🔊 ♻️ improve error tracing in metadata file * chore: 🔨 remove todo * refactor: ✨ ♻️ abstracted Zenodo workflow (bot) * wip: 🚧 save custom license content when no assertion is provided * ✨ feat: add support for custom licenses (#90) * ✨ feat: add support for custom licenses * 🐛 fix: reset citation license field * 🐛 fix: update zenodo workflow for custom licenses * fix: 🐛 license is valid with custom license * feat: ✨ custom license template * ✨ feat: update codemeta, license and cwl ui paths (#91) * ✨ feat: update meta paths for consistency * 🚚 fix: updatel icense request path * ✨ feat: add support for custom license title (#92) * refactor: ♻️ ✨ new patches for license, cwl, metadata UI's * refactor: ✨ ♻️ apply migrations from UI to bot * feat: ✨ request custom license title from user * refactor: ♻️ hide message box when custom license title is blank * refactor: ♻️ issue dashboard requests custom title * feat: ✨ Saving custom title (#93) * feat: ✨ save custom title option * refactor: :recyle: reuse saveLicenseDraft for storing custom license title * refactor: ♻️ join draft and save title buttons together * refactor: ♻️ use naive-ui's properties for styling * chore: 🔨 remove typo * chore: 🔨 remove unused variables * feat: ✨ toasts for custom title saved button * refactor: ♻️ function rename * feat: ✨ create Zenodo metadata fn handles custom licenses * feat: ✨ custom license reference for archival workflow * refactor: ♻️ stop creating identifiers for new db entries * refactor: ♻️ 🐛 revert allowing custom licenses for zenodo * refactor: ♻️ Custom License Support (#94) * refactor: ♻️ ✨ custom title saved updates dashboard, disable create release btn when custom license * refactor: ♻️ block progress of fair release if license is custom * feat: ✨ listener for when custom license title is saved through UI * feat: ✨ prevent fair release if not fair compliant * refactor: ♻️ improve license validation and update template text for custom licenses * refactor: ♻️ re-render issue from ui side * refactor: ♻️ update to message explaining custom licenses * db calls running in parallel * fix: 🐛 prevent Zendo section from being seen when the license is custom * fix: 🐛 trim license content before comparison --------- Co-authored-by: Sanjay Soundarajan <sanjay.16@live.com>
* fix: 🐛 rerender template will stop using old links * doc: 📝 update CHANGELOG * doc: 📝 update metadata
Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again! |
Reviewer's Guide by SourceryThis PR implements deployment environments for the application using Kamal, a deployment tool. The changes include setting up production and staging environments, configuring Docker builds, and updating environment variable references. The deployment setup includes SSL certification, health checks, and secrets management. Class diagram for environment variable updatesclassDiagram
class EnvironmentVariables {
+String DOCKER_BUILDKIT
+String KAMAL_REGISTRY_LOGIN_SERVER
+String KAMAL_REGISTRY_USERNAME
+String KAMAL_REGISTRY_PASSWORD
+String KAMAL_SERVER_IP
+String DATABASE_URL
+String APP_ID
+String GH_APP_ID
+String GH_APP_NAME
+String GH_CLIENT_ID
+String GH_CLIENT_SECRET
+String PRIVATE_KEY
+String WEBHOOK_SECRET
+String CODEFAIR_APP_DOMAIN
+String CODEFAIR_BOT_DOMAIN
+String ZENODO_API_ENDPOINT
+String ZENODO_ENDPOINT
}
note for EnvironmentVariables "Updated environment variable references for deployment"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @megasanjay - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Thanks for closing this pull request! If you have any further questions, please feel free to open a new issue. We are always happy to help! |
Summary by Sourcery
Set up deployment environments for production and staging, updating CI workflows to support these environments with concurrency control. Modify Dockerfile to optimize build and runtime stages, and update environment variable references across the codebase. Add deployment configuration files and hooks for Kamal, and update changelog to reflect recent changes.
CI:
Deployment: