✨ feat: add support for custom license title

[megasanjay]

Summary by Sourcery

Add support for custom license titles, allowing users to specify a title for custom licenses in the license management system. Update the user interface to include a field for custom license titles and ensure proper handling of this new field in the backend API and database.

New Features:

• Add support for custom license titles in the license management system.

Enhancements:

• Improve the user interface to include a field for entering custom license titles when a custom license is selected.

[fairdataihub-bot]

Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again!

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR adds support for custom license titles in the license management system. The implementation includes UI changes to collect and display custom license titles, backend updates to store this information, and modifications to the Zenodo release workflow to properly handle custom licenses.

ER diagram for LicenseRequest table changes

erDiagram
    LicenseRequest {
        string license_id
        string license_content
        string custom_license_title
    }
    note for LicenseRequest "Added custom_license_title column"

Loading

Updated class diagram for LicenseRequest

classDiagram
    class LicenseRequest {
        +string licenseId
        +string licenseContent
        +string customLicenseTitle
    }
    class LicenseRequestGetResponse {
        +string licenseId
        +string licenseContent
        +string customLicenseTitle
        +number timestamp
    }
    LicenseRequest <|-- LicenseRequestGetResponse
    note for LicenseRequest "Added customLicenseTitle attribute"

Loading

File-Level Changes

Change	Details	Files
Added custom license title support in the license editor	Added new input field for custom license title when 'Custom' license is selected Added validation to require custom license title for custom licenses Updated license request data structure to include customLicenseTitle field	ui/pages/dashboard/[owner]/[repo]/edit/license.vue ui/types/license.d.ts
Updated backend API endpoints to handle custom license titles	Added customLicenseTitle to request body schema Added custom_license_title column to LicenseRequest table Updated API responses to include custom license title information	ui/server/api/[owner]/[repo]/license/index.put.ts ui/server/api/[owner]/[repo]/license/index.post.ts ui/server/api/[owner]/[repo]/license/index.get.ts ui/prisma/migrations/20241025215938_custom_license_title/migration.sql
Modified Zenodo release workflow to support custom licenses	Removed restriction on creating releases with custom licenses Updated license validation to check for custom license title Modified metadata generation to handle custom licenses properly	ui/pages/dashboard/[owner]/[repo]/release/zenodo.vue ui/pages/dashboard/[owner]/[repo]/index.vue ui/server/api/[owner]/[repo]/code-metadata/index.post.ts ui/server/api/[owner]/[repo]/release/zenodo/index.get.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[fairdataihub-bot]

Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions!

[sourcery-ai]

Hey @megasanjay - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider making the custom_license_title field nullable in the database instead of using an empty string default. This helps distinguish between cases where no title was provided versus an explicitly empty title.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion: Consider extracting duplicate license validation logic into a helper function

The same validation logic appears in both saveLicenseDraft and saveLicenseAndPush. Creating a validateLicense helper function would improve maintainability.

function validateCustomLicense(licenseId: string, customLicenseTitle: string): boolean {
  return !(licenseId === "Custom" && !customLicenseTitle.trim());
}

if (!validateCustomLicense(licenseId.value, customLicenseTitle.value)) {

[fairdataihub-bot]

Thanks for closing this pull request! If you have any further questions, please feel free to open a new issue. We are always happy to help!