fix: 🐛 Zenodo callback issue resolved with purging token before sign in

[slugb0t]

Summary by Sourcery

Bug Fixes:

• Resolve Zenodo callback issue by purging the Zenodo token before signing in.

[fairdataihub-bot]

Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again!

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR fixes a Zenodo callback issue by implementing a token purging mechanism before sign-in. The implementation adds a new API endpoint for deleting Zenodo tokens and modifies the login flow to ensure clean authentication state.

Sequence diagram for Zenodo login process

sequenceDiagram
    actor User
    participant Frontend
    participant Backend
    participant Zenodo

    User->>Frontend: Click 'Login to Zenodo'
    Frontend->>Backend: DELETE /api/user/zenodo
    Backend-->>Frontend: Zenodo token purged
    Frontend->>Zenodo: Redirect to Zenodo login page
    Zenodo-->>User: Zenodo login page

Loading

Class diagram for Zenodo token management

classDiagram
    class ZenodoToken {
        +String user_id
    }
    class User {
        +String id
    }
    class ZenodoDeleteHandler {
        +handleRequest(event)
    }
    ZenodoDeleteHandler --> ZenodoToken : deletes
    ZenodoDeleteHandler --> User : requires
    note for ZenodoDeleteHandler "Handles the deletion of Zenodo tokens for a user"

Loading

File-Level Changes

Change	Details	Files
Added new API endpoint for purging Zenodo tokens	Created new DELETE endpoint for removing Zenodo tokens Implemented user authentication check Added prisma query to delete all Zenodo tokens for the user	ui/server/api/user/zenodo.delete.ts
Modified Zenodo login flow to include token purging	Created new loginToZenodo function to handle the login process Added token purging API call before redirecting to Zenodo Updated login button to use the new login function instead of direct URL navigation Added error handling for token purging failures	ui/pages/dashboard/[owner]/[repo]/release/zenodo.vue
Updated Vue components type definitions	Removed unused component imports Cleaned up component declarations	ui/components.d.ts

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[fairdataihub-bot]

Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions!

[what-the-diff]

PR Summary

• Efficiency Improvements in Import Usage
  Unused imports related to various components (like NCollapseTransition, NDatePicker, NDynamicInput, NPopconfirm, and NSpace) were removed from ui/components.d.ts, leading to a cleaner codebase.

• Enhancements in Zenodo Token Handling
  A new function for handling Zenodo token named loginToZenodo has been introduced in zenodo.vue. This function can detect the absence of a valid token and then redirects to the Zenodo login page, improving user flow.

• Optimization of Zenodo Login Link
  The Zenodo login link in zenodo.vue has been updated to use the newly implemented loginToZenodo function, instead of needing a direct link. This ensures a consistent and cohesive login experience across the platform.

• Additional API Endpoint for Token Deletion
  A fresh API endpoint has been set up in zenodo.delete.ts to handle DELETE requests and, thereby, purges the Zenodo token from the database when required. This adds another layer of security and functionality to our data management.

[sourcery-ai]

Hey @slugb0t - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): Error message is incorrect - user is expected in context, not URL params

[sourcery-ai]

suggestion (bug_risk): Add preventDefault to click handler to ensure custom login flow works correctly

The anchor tag's default behavior might interfere with the custom login flow. Consider using @click.prevent="loginToZenodo".

Suggested change

	<a v-if="!haveValidZenodoToken" @click="loginToZenodo">
	<a v-if="!haveValidZenodoToken" @click.prevent="loginToZenodo">

[fairdataihub-bot]

Thanks for closing this pull request! If you have any further questions, please feel free to open a new issue. We are always happy to help!