-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ ♻️ 🐛 Codefair v3.1.0 #95
Conversation
* fix: 🐛 patch removing pull_request.closed bug on metadata pr merge * fix: 🐛 don't update firstPublished in the codemeta file + better logs * fix: 🐛 patch error on reading db entry when it doesn't exist * chore: 🔊 better log on successful Zenodo publish * style: 🎨 margins between text and icon * feat: ✨ links to the list of tools used for codefair in /codefair * refactor: ✨ ♻️ abstract the license validation fn * doc: 🔖 update changelog * feat: ✨ ♻️ abstraction to zenodo workflow * wip: 🚧 abstracting zenodo workflow * feat: ✨ add help link in the Zenodo release page * refactor: ♻️ ✨ abstract out github release functions * refactor: 🔊 ♻️ improve error tracing in metadata file * chore: 🔨 remove todo * refactor: ✨ ♻️ abstracted Zenodo workflow (bot) * wip: 🚧 save custom license content when no assertion is provided * ✨ feat: add support for custom licenses (#90) * ✨ feat: add support for custom licenses * 🐛 fix: reset citation license field * 🐛 fix: update zenodo workflow for custom licenses * fix: 🐛 license is valid with custom license * feat: ✨ custom license template * ✨ feat: update codemeta, license and cwl ui paths (#91) * ✨ feat: update meta paths for consistency * 🚚 fix: updatel icense request path * ✨ feat: add support for custom license title (#92) * refactor: ♻️ ✨ new patches for license, cwl, metadata UI's * refactor: ✨ ♻️ apply migrations from UI to bot * feat: ✨ request custom license title from user * refactor: ♻️ hide message box when custom license title is blank * refactor: ♻️ issue dashboard requests custom title * feat: ✨ Saving custom title (#93) * feat: ✨ save custom title option * refactor: :recyle: reuse saveLicenseDraft for storing custom license title * refactor: ♻️ join draft and save title buttons together * refactor: ♻️ use naive-ui's properties for styling * chore: 🔨 remove typo * chore: 🔨 remove unused variables * feat: ✨ toasts for custom title saved button * refactor: ♻️ function rename * feat: ✨ create Zenodo metadata fn handles custom licenses * feat: ✨ custom license reference for archival workflow * refactor: ♻️ stop creating identifiers for new db entries * refactor: ♻️ 🐛 revert allowing custom licenses for zenodo * refactor: ♻️ Custom License Support (#94) * refactor: ♻️ ✨ custom title saved updates dashboard, disable create release btn when custom license * refactor: ♻️ block progress of fair release if license is custom * feat: ✨ listener for when custom license title is saved through UI * feat: ✨ prevent fair release if not fair compliant * refactor: ♻️ improve license validation and update template text for custom licenses * refactor: ♻️ re-render issue from ui side * refactor: ♻️ update to message explaining custom licenses * db calls running in parallel * fix: 🐛 prevent Zendo section from being seen when the license is custom * fix: 🐛 trim license content before comparison --------- Co-authored-by: Sanjay Soundarajan <sanjay.16@live.com>
Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again! |
Reviewer's Guide by SourceryThis pull request implements significant changes to improve the handling of custom licenses, refactor API routes, and enhance error handling throughout the application. The changes focus on streamlining the license management workflow and improving the user experience when dealing with custom licenses. Sequence diagram for Zenodo deposition processsequenceDiagram
actor User
participant App
participant Zenodo
participant GitHub
User->>App: Request Zenodo deposition
App->>GitHub: Fetch metadata
App->>Zenodo: Create or fetch deposition
App->>GitHub: Update metadata with DOI
App->>Zenodo: Upload assets
App->>Zenodo: Publish deposition
App->>GitHub: Update release status
App->>User: Notify completion
Class diagram for updated license managementclassDiagram
class LicenseRequest {
+String licenseId
+String licenseContent
+String customLicenseTitle
+Date updatedAt
}
class LicenseManager {
+validateLicense(licenseRequest, existingLicense)
+applyLicenseTemplate(context, owner, repository, subjects)
}
LicenseRequest --> LicenseManager : uses
note for LicenseRequest "Handles license data including custom titles"
note for LicenseManager "Manages license validation and application"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions! |
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @slugb0t - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Thanks for closing this pull request! If you have any further questions, please feel free to open a new issue. We are always happy to help! |
Summary by Sourcery
Introduce a new workflow to streamline GitHub release integration with Zenodo archiving, ensuring metadata is updated before releases. Add support for custom license titles and improve error handling and logging. Fix issues with metadata PR links and codemeta.json date updates. Enhance the UI with additional resources and improved layouts.
New Features:
Bug Fixes:
Enhancements:
Documentation: