Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set lint warnings to error #1431

Closed
ST-DDT opened this issue Oct 11, 2022 · 1 comment · Fixed by #1714
Closed

Set lint warnings to error #1431

ST-DDT opened this issue Oct 11, 2022 · 1 comment · Fixed by #1714
Assignees
@ST-DDT
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.0 - Module Re-...

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Oct 11, 2022

Clear and concise description of the problem

We previously fixed all lint warnings in our code, then we accidentally introduced a lint "warning" to our code.

Suggested solution

Set lint levels to error, so that the build pipeline fails, if these things are added.

Alternative

Manually check for lint warnings in each PR.

Additional context

No response
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision c: infra Changes to our infrastructure or project setup labels Oct 11, 2022
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Oct 11, 2022
@xDivisionByZerox
Copy link
Member

I like the idea. We have these rules for a reason, no reason to allow bypassing them.

@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Oct 12, 2022
@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Nov 8, 2022
@ST-DDT ST-DDT self-assigned this Jan 6, 2023
@ST-DDT ST-DDT mentioned this issue Jan 6, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Faker Roadmap Jan 7, 2023
@ST-DDT ST-DDT mentioned this issue May 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging a pull request may close this issue.

infra: set lint warnings to error faker-js/faker
2 participants
@ST-DDT @xDivisionByZerox