test: lint vitest

[Shinigami92]

Lint with https://www.npmjs.com/package/eslint-plugin-vitest

[codecov]

Codecov Report

Merging #2098 (d23101c) into next (1c9043b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2098      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2605     2605              
  Lines      244951   244951              
  Branches     1150     1145       -5     
==========================================
- Hits       243969   243957      -12     
- Misses        955      967      +12     
  Partials       27       27              

see 1 file with indirect coverage changes

[Shinigami92]

I think this is a good start

But there are more rules to explore later in future PRs like

• prefer-each
• prefer-lowercase-title
• prefer-spy-on
• prefer-to-contain

[ST-DDT]

Please set the lint level to error. Since there is no point in just warning about errors and then ignoring them.

[Shinigami92]

Please set the lint level to error. Since there is no point in just warning about errors and then ignoring them.

you might have read something different
there is no 'warn'?!
please point me where you have read that

[ST-DDT]

You haven't done explicitly here, but implicitly (or there is a config error somewhere).

As per #1431 we decided to use error for lint rules to prevent accidentally adding warnings, that don't get fixed.

• Set lint warnings to error #1431
• infra: set lint warnings to error #1714

To prevent cases like these that "pollute" the build logs.

(If it is important, then it should be fixed. If it isn't important, why clutter the logs with warnings.)

I don't care whether we explicitly configure them to error or consider warnings to be errors in CI.
For preflight it might be best, if we fail in the same cases as the CI/when there are warnings.

[Shinigami92]

You haven't done explicitly here, but implicitly (or there is a config error somewhere).

As per #1431 we decided to use error for lint rules to prevent accidentally adding warnings, that don't get fixed.

• Set lint warnings to error #1431
• infra: set lint warnings to error #1714

To prevent cases like these that "pollute" the build logs.

(If it is important, then it should be fixed. If it isn't important, why clutter the logs with warnings.)

I don't care whether we explicitly configure them to error or consider warnings to be errors in CI. For preflight it might be best, if we fail in the same cases as the CI/when there are warnings.

The issue is now open and requested at upstream

[Shinigami92]

will rebase after the dep updates