Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: set lint warnings to error #1714

Merged
merged 1 commit into from
Jan 7, 2023
Merged

infra: set lint warnings to error #1714

merged 1 commit into from
Jan 7, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 6, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: infra Changes to our infrastructure or project setup labels Jan 6, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Jan 6, 2023
@ST-DDT ST-DDT requested review from a team January 6, 2023 09:50
@ST-DDT ST-DDT self-assigned this Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #1714 (7e90f96) into next (95d0765) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1714   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2262     2262           
  Lines      240707   240707           
  Branches     1095     1095           
=======================================
  Hits       239825   239825           
  Misses        861      861           
  Partials       21       21

@ST-DDT ST-DDT merged commit 35f3869 into next Jan 7, 2023
@ST-DDT ST-DDT deleted the infra/lint/error branch January 7, 2023 15:40
@ST-DDT ST-DDT mentioned this pull request May 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Set lint warnings to error
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox