Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): extend english company #1701

Merged
merged 8 commits into from
Jan 2, 2023
Merged

feat(locale): extend english company #1701

merged 8 commits into from
Jan 2, 2023

Conversation

Busyvar
Copy link
Contributor

@Busyvar Busyvar commented Dec 30, 2022

Add lifetime value as new company buzzword.
related to #1700

@Busyvar Busyvar requested a review from a team as a code owner December 30, 2022 19:24
@import-brain import-brain added c: feature Request for new feature p: 1-normal Nothing urgent c: locale Permutes locale definitions m: company Something is referring to the company module labels Dec 30, 2022
Shinigami92
Shinigami92 previously approved these changes Dec 31, 2022
@Shinigami92 Shinigami92 requested review from a team December 31, 2022 17:53
@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Merging #1701 (c77ef90) into next (496c40b) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1701   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2245     2245           
  Lines      240400   240396    -4     
  Branches     1079     1079           
=======================================
- Hits       239525   239521    -4     
  Misses        854      854           
  Partials       21       21           
Impacted Files Coverage Δ
src/locales/en/company/bs_noun.ts 100.00% <100.00%> (ø)

ST-DDT
ST-DDT previously approved these changes Dec 31, 2022
@ST-DDT ST-DDT requested review from import-brain and a team December 31, 2022 18:20
import-brain
import-brain previously approved these changes Jan 1, 2023
@matthewmayer
Copy link
Contributor

I noticed some of the nouns in bs_noun are pretty dated, they sound very much like 2000s era dot-com words

i would nominate the following for deletion

infomediaries
vortals
e-tailers
web-readiness

@ST-DDT
Copy link
Member

ST-DDT commented Jan 1, 2023

I agree. Should we do that as part of this PR or a new one? @Busyvar do you have time to remove those values?

@Busyvar Busyvar dismissed stale reviews from import-brain, ST-DDT, and Shinigami92 via bb1dfed January 1, 2023 12:56
@Busyvar
Copy link
Contributor Author

Busyvar commented Jan 1, 2023

I agree. Should we do that as part of this PR or a new one? @Busyvar do you have time to remove those values?

Changes partially made, i must rely on CI output to fix tests because my dev setup is not ready for local tests.

@Shinigami92
Copy link
Member

Changes partially made, i must rely on CI output to fix tests because my dev setup is not ready for local tests.

Can you explain whether you have locally problems to set it up?
Could something like this help you? #1652
Did you know you can press . (dot) on your keyboard withing the PR here on GitHub to open a VSCode in your browser?

@Busyvar
Copy link
Contributor Author

Busyvar commented Jan 1, 2023

Changes partially made, i must rely on CI output to fix tests because my dev setup is not ready for local tests.

Can you explain whether you have locally problems to set it up? Could something like this help you? #1652 Did you know you can press . (dot) on your keyboard withing the PR here on GitHub to open a VSCode in your browser?

I will take a look next time how to fix this problem. For now no more changes are required regarding this PR.

@Shinigami92 Shinigami92 merged commit f0e859b into faker-js:next Jan 2, 2023
pladreyt pushed a commit to pladreyt/faker that referenced this pull request Jan 3, 2023
pladreyt pushed a commit to pladreyt/faker that referenced this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: locale Permutes locale definitions m: company Something is referring to the company module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants