-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): extend english company #1701
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1701 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2245 2245
Lines 240400 240396 -4
Branches 1079 1079
=======================================
- Hits 239525 239521 -4
Misses 854 854
Partials 21 21
|
I noticed some of the nouns in bs_noun are pretty dated, they sound very much like 2000s era dot-com words i would nominate the following for deletion
|
I agree. Should we do that as part of this PR or a new one? @Busyvar do you have time to remove those values? |
bb1dfed
Changes partially made, i must rely on CI output to fix tests because my dev setup is not ready for local tests. |
Can you explain whether you have locally problems to set it up? |
I will take a look next time how to fix this problem. For now no more changes are required regarding this PR. |
Add lifetime value as new company buzzword.
related to #1700