-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: setup dev-container #1652
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1652 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2337 2336 -1
Lines 241178 241123 -55
Branches 1098 1102 +4
=======================================
- Hits 240294 240241 -53
+ Misses 863 861 -2
Partials 21 21
|
I just checked this PR branch out and "Reopen in in container" locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After allowing the "unsafe" git repo (prompt from VS Code) I could do the following things:
- ✅update code and commit it
- ✅install the dependencies (happens automatically)
- ✅build the project
- ✅build the docs
- ✅serve the docs
- ✅run linter
- ✅run tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve so it's not blocking, but feel free to rethink about vscode recommendation
it could get annoying to recommend extensions that are not really needed at the end of the day
And updates for this PR? |
Review Usage:
pnpm run test
,pnpm run docs:dev
... as you would do locallyLater Usage:
pnpm run test
,pnpm run docs:dev
... as you would do locallyThis is an optional feature, which may (or may not) help external contributors.