-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helpers): new method objectEntry
#2123
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyashgulati
commented
May 3, 2023
matthewmayer
requested changes
May 3, 2023
matthewmayer
requested changes
May 3, 2023
matthewmayer
changed the title
feat(helpers): Added new helper method 'ObjectEntry'
feat(helpers): Added new helper method 'objectEntry'
May 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2123 +/- ##
=======================================
Coverage 99.58% 99.59%
=======================================
Files 2605 2605
Lines 244944 244969 +25
Branches 1250 1249 -1
=======================================
+ Hits 243939 243968 +29
+ Misses 978 974 -4
Partials 27 27
|
Shinigami92
added
c: feature
Request for new feature
p: 1-normal
Nothing urgent
m: helpers
Something is referring to the helpers module
labels
May 3, 2023
@Shinigami92 Can you also assign issue #1764 to me as well. |
github doesn't let me select you, maybe you need to write a comment there |
ST-DDT
reviewed
May 3, 2023
matthewmayer
requested changes
May 3, 2023
xDivisionByZerox
approved these changes
May 3, 2023
Shinigami92
approved these changes
May 3, 2023
Shinigami92
changed the title
feat(helpers): Added new helper method 'objectEntry'
feat(helpers): new method May 3, 2023
objectEntry
matthewmayer
approved these changes
May 3, 2023
ST-DDT
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: feature
Request for new feature
m: helpers
Something is referring to the helpers module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #1764, added a new helper method named
faker.helpers.objectEntry
that will return a random key-value pair from the given object.Changes made:
faker.helpers.objectEntry